Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • N noc
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 445
    • Issues 445
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 30
    • Merge requests 30
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • noc
  • noc
  • Merge requests
  • !5860

Fix trace when remove address from trap/syslog source.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andrey Vertiprahov requested to merge fix-avs-trapsourceupdate-trace into master Nov 07, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Fix trace when remove address from trap/syslog source.

Fix trace:

ERROR FINGERPRINT: 57e6ee85-3583-5365-8b21-ce530a6afb74
WORKING DIRECTORY: /opt/noc
EXCEPTION: <class 'KeyError'> '10.0.0.3'
START OF TRACEBACK
------------------------------------------------------------------------
File: services/trapcollector/service.py (Line: 153)
Function: update_source
  146             )
  147             new_addresses = set(cfg.addresses)
  148             # Add new addresses, update remaining
  149             for addr in new_addresses:
  150                 self.address_configs[addr] = cfg
  151             # Revoke stale addresses
  152             for addr in old_addresses - new_addresses:
  153 ==>             del self.address_configs[addr]
  154             # Update configs
  155             self.source_configs[data["id"]] = cfg
  156             # Update metrics
  157             metrics["sources_changed"] += 1
  158     
  159         async def delete_source(self, id):
Variables:
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-avs-trapsourceupdate-trace