Merge branch 'cherry-pick-0671f995' into 'release-20.4'

release-20.4:Backport!5748 Ansible fix changed_when

See merge request !5872

ansible/noc_roles/migrate/tasks/main.yml

@@ -55,7 +55,7 @@
     chdir: "{{ noc_root }}"
   become: "True"
   become_user: "{{ noc_user }}"
-  changed_when: "False"
+  changed_when: false
 
 - name: Apply pools
   command: "{{ noc_root }}/scripts/deploy/apply-pools"

ansible/noc_roles/noc/tasks/tests.yml

@@ -3,7 +3,7 @@
   - name: check if supervisord running
     command: pgrep -f supervisord -c
     failed_when: "False"
-    changed_when: "False"
+    changed_when: false
     register: supervisord_running
     check_mode: "False"
 
@@ -17,7 +17,7 @@
   - name: check if noc services are down
     shell: /opt/noc/noc ctl status | grep -v RUNNING
     become: "True"
-    changed_when: "False"
+    changed_when: false
     register: noc_status
     failed_when: "False"
     check_mode: "False"

ansible/noc_roles/post/tasks/main.yml

@@ -3,7 +3,7 @@
 - name: check if noc running
   command: "{{ noc_root }}/noc ctl status"
   check_mode: "False"
-  changed_when: "False"
+  changed_when: false
   register: noc_ctl_status
   when: tower_serial_restart_noc
 
@@ -17,7 +17,7 @@
 - name: Serial NOC restart
   command: "{{ noc_root }}/noc ctl serialrestart all"
   when: tower_serial_restart_noc
-  changed_when: "False"
+  changed_when: false
 
 - name: Restart NOC node
   service:

ansible/noc_roles/pre/tasks/main.yml

@@ -41,7 +41,7 @@
     state: stopped
   become: "True"
   failed_when: "False"
-  changed_when: "False"
+  changed_when: false
   when: tower_stop_noc
 
 - name: Setup hostname

ansible/system_roles/clickhouse/tasks/checks.yml

@@ -28,7 +28,7 @@
           command: grep -q sse4_2 /proc/cpuinfo
           register: sse42_support
           failed_when: "False"
-          changed_when: "False"
+          changed_when: false
           check_mode: "False"
 
         - name: fail if SSE 4.2 not supported
@@ -47,7 +47,7 @@
           command: grep -q SSE4.2 /var/run/dmesg.boot
           register: sse42_support
           failed_when: "False"
-          changed_when: "False"
+          changed_when: false
           check_mode: "False"
 
         - name: fail if SSE 4.2 not supported

ansible/system_roles/clickhouse/tasks/tests.yml

@@ -3,7 +3,7 @@
   - name: check if clickhouse-server running
     command: pgrep -f clickhouse-server -c
     failed_when: "False"
-    changed_when: "False"
+    changed_when: false
     register: clickhouse_server_running
     check_mode: "False"
 

ansible/system_roles/consul-template/tasks/install.yml

@@ -17,7 +17,7 @@
   delegate_to: 127.0.0.1
   become: "False"
   run_once: "True"
-  changed_when: "False"
+  changed_when: false
 
 - name: Download Consul-template
   get_url:

ansible/system_roles/consul-template/tasks/tests.yml

@@ -3,7 +3,7 @@
   - name: check if consul_template running
     command: pgrep -x consul-template -c
     failed_when: "False"
-    changed_when: "False"
+    changed_when: false
     register: consul_template_running
     check_mode: "False"
 

ansible/system_roles/consul/tasks/install.yml

@@ -17,7 +17,7 @@
   delegate_to: 127.0.0.1
   become: "False"
   run_once: "True"
-  changed_when: "False"
+  changed_when: false
 
 - name: Download Consul
   get_url:

ansible/system_roles/consul/tasks/main.yml

@@ -2,7 +2,7 @@
 # File: main.yml - Main tasks for Consul
 
 - name: make servers group
-  changed_when: "False"
+  changed_when: false
   add_host:
     group: svc-consul-server
     host: "{{ item }}"