Make int lintable

.yamllint

@@ -45,12 +45,12 @@ rules:
     # Defaults
     # spaces: consistent
     # indent-sequences: true
-    # check-multi-line-strings: false
+    check-multi-line-strings: true
 
     # Requiring 2 space indentation
-    spaces: 2
+    spaces: consistent
     # Requiring consistent indentation within a file, either indented or not
-    indent-sequences: consistent
+    indent-sequences: true
 
   # Disabling due to copious amounts of long lines in the code which would
   # require a code style change to resolve
@@ -62,7 +62,7 @@ rules:
 
   # Disabling due to copious amounts of truthy warnings in the code which would
   # require a code style change to resolve
-  truthy: disable
+  truthy: enable
     # Defaults
     # level: warning
-
+  key-duplicates: enable

ansible/deploy.yml

+---
 - import_playbook: pre.yml
 
 - name: Install NOC
   hosts: noc-svc-*
-  become: yes
+  become: "True"
   strategy: "{% if groups['svc-noc-exec'] > 2 %}free{%else%}linear{%endif%}"
-  gather_facts: True
+  gather_facts: "True"
   tags:
     - node
     - noc
@@ -35,9 +36,9 @@
     - role: discovery
     - role: bi
     - role: migrate
-      become: yes
-      run_once: true
+      become: "True"
+      run_once: "True"
       tags:
         - migrate
 
-- import_playbook: post.yml
\ No newline at end of file
+- import_playbook: post.yml

ansible/noc_roles/activator/handlers/main.yml

----
-- name: reload telegraf
-  become: yes
-  service:
-    name: telegraf
-    state: reloaded

ansible/noc_roles/activator/meta/tower.yml

@@ -14,7 +14,7 @@ forms:
       type: int
       max: 64
       min: 0
-      required: True
+      required: "True"
     loglevel:
       default: info
       label: Loglevel
@@ -30,12 +30,12 @@ forms:
       default: 20
       label: "Script threads"
       type: int
-      required: True
+      required: "True"
     tos:
       default: 0
       label: "IP ToS mark"
       type: int
-      required: True
+      required: "True"
 
 services:
   activator:
@@ -53,4 +53,3 @@ services:
       stdout_logfile_backups: 3
       stdout_logfile_maxbytes: 10MB
       stopwaitsecs: 3
-

ansible/noc_roles/activator/tasks/checks.yml

+---
 - name: fail if noc is not selected
   fail:
     msg: "Activator role have to be set with noc role to get own sources."
   when:
     - has_svc_activator is defined
     - has_svc_noc is not defined
+  tags:
+    - checks

ansible/noc_roles/activator/tasks/main.yml

@@ -42,7 +42,7 @@
     name: "{{item.name}}"
     value: "{{item.value}}"
     state: present
-    reload: yes
+    reload: "True"
   with_items:
     - { name: 'net.ipv4.tcp_no_metrics_save', value: 1}
     - { name: 'net.ipv4.tcp_window_scaling', value: 0}

ansible/noc_roles/activator/tasks/os/CentOS/main.yml

@@ -2,7 +2,7 @@
 - name: Install CentOS system packages
   yum:
     name: "{{ item }}"
-    update_cache: yes
+    update_cache: "True"
   with_items:
     - libssh2
     - libssh2-devel

ansible/noc_roles/activator/tasks/os/Debian/main.yml

@@ -2,7 +2,7 @@
 - name: Install Debian system packages
   apt:
     name: "{{item}}"
-    update_cache: yes
+    update_cache: "True"
     cache_valid_time: "{{apt_cache_valid_time | default (3600)}}"
   with_items:
     - libssh2-1

ansible/noc_roles/activator/tasks/os/RedHat/main.yml

@@ -2,7 +2,7 @@
 - name: Install RedHat system packages
   yum:
     name: "{{item}}"
-    update_cache: yes
+    update_cache: "True"
   with_items:
     - libssh2
     - libssh2-devel

ansible/noc_roles/activator/tasks/os/Ubuntu/main.yml

@@ -2,7 +2,7 @@
 - name: Install Ubuntu system packages
   apt:
     name: "{{item}}"
-    update_cache: yes
+    update_cache: "True"
     cache_valid_time: "{{apt_cache_valid_time | default (3600)}}"
   with_items:
     - libssh2-1

ansible/noc_roles/bi/defaults/main.yml

+---
 required_assets:
-  - bi
\ No newline at end of file
+  - bi

ansible/noc_roles/bi/handlers/main.yml

----
-- name: reload telegraf
-  become: yes
-  service:
-    name: telegraf
-    state: reloaded

ansible/noc_roles/bi/meta/tower.yml

@@ -40,7 +40,6 @@ forms:
       max: 100
       min: 5
 
-
 services:
   bi:
     level: global
@@ -57,4 +56,4 @@ services:
       - bi
     depends:
       - noc
-      - clickhouse
\ No newline at end of file
+      - clickhouse

ansible/noc_roles/bi/tasks/checks.yml

-- name: Mongo version is too old
-  fail:
-    msg: |
-      To use bi you have to setup at least 3.4 mongo.
-      Check https://kb.nocproject.org/x/TIHJAQ for more details.
-      Current version selected:  {{mongod_version}}
-      Otherwise you can disable bi service on services tab
-  when:
-    - has_svc_bi is defined
-    - mongod_version is version_compare('3.4', operator='lt', strict=True)
+---
+- block:
+  - name: Mongo version is too old
+    fail:
+      msg: |
+        To use bi you have to setup at least 3.4 mongo.
+        Check https://kb.nocproject.org/x/TIHJAQ for more details.
+        Current version selected:  {{mongod_version}}
+        Otherwise you can disable bi service on services tab
+    when:
+      - mongod_version is version_compare('3.4', operator='lt', strict=True)
 
-- name: fail if noc is not selected
-  fail:
-    msg: "Bi role have to be set with noc role to get own sources."
+  - name: fail if noc is not selected
+    fail:
+      msg: "Bi role have to be set with noc role to get own sources."
+    when:
+      - has_svc_noc is not defined
   when:
     - has_svc_bi is defined
-    - has_svc_noc is not defined

ansible/noc_roles/bi/tasks/main.yml

+---
 - name: "Include OS-specific tasks"
   include_tasks: "os/{{ ansible_distribution }}/main.yml"
 
@@ -13,4 +14,4 @@
     https_proxy: "{{http_proxy}}"
     NOC_CONFIG: "{{config_order}}"
   tags:
-    - requirements
\ No newline at end of file
+    - requirements

ansible/noc_roles/card/defaults/main.yml

+---
 required_assets:
   - card
-  - web
\ No newline at end of file
+  - web

ansible/noc_roles/card/handlers/main.yml

----
-- name: reload telegraf
-  become: yes
-  service:
-    name: telegraf
-    state: reloaded

ansible/noc_roles/card/meta/tower.yml

@@ -52,4 +52,4 @@ services:
       - web
     depends:
       - noc
-      - nginx
\ No newline at end of file
+      - nginx

ansible/noc_roles/card/tasks/checks.yml

+---
 - name: fail if noc is not selected
   fail:
     msg: "Card role have to be set with noc role to get own sources."

ansible/noc_roles/card/tasks/main.yml

+---
 - name: "Include OS-specific tasks"
   include_tasks: "os/{{ ansible_distribution }}/main.yml"
 
@@ -13,4 +14,4 @@
     https_proxy: "{{http_proxy}}"
     NOC_CONFIG: "{{config_order}}"
   tags:
-    - requirements
\ No newline at end of file
+    - requirements